<html>
<head><meta charset="utf-8"><title>perf checks by wg · t-compiler/wg-prioritization · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/index.html">t-compiler/wg-prioritization</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html">perf checks by wg</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="198329167"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198329167" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198329167">(May 21 2020 at 14:46)</a>:</h4>
<p>opening this for discussion</p>



<a name="198329180"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198329180" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198329180">(May 21 2020 at 14:46)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="116083">@pnkfelix</span></p>



<a name="198329200"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198329200" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198329200">(May 21 2020 at 14:47)</a>:</h4>
<p>it would be great to define exactly what should we check and how often</p>



<a name="198333718"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198333718" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198333718">(May 21 2020 at 15:19)</a>:</h4>
<p>yeah I'm not sure</p>



<a name="198333732"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198333732" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198333732">(May 21 2020 at 15:19)</a>:</h4>
<p>its important we have something simple to look at</p>



<a name="198333765"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198333765" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198333765">(May 21 2020 at 15:19)</a>:</h4>
<p>I think the weekly inspection makes sense, if it can be as quick as it as been</p>



<a name="198333849"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198333849" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198333849">(May 21 2020 at 15:20)</a>:</h4>
<p>the main issue is what metrics to look at.</p>



<a name="198333892"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198333892" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198333892">(May 21 2020 at 15:20)</a>:</h4>
<p>(another issue is "how to interpret what we look at" -- in other words, what is a red flag indicating we need to discuss at the meeting)</p>



<a name="198333920"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198333920" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198333920">(May 21 2020 at 15:20)</a>:</h4>
<p>today's meeting led me to wonder if we should be including code size metrics</p>



<a name="198333934"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198333934" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198333934">(May 21 2020 at 15:21)</a>:</h4>
<p>rather than just instruction count metrics</p>



<a name="198341384"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198341384" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198341384">(May 21 2020 at 16:19)</a>:</h4>
<p>I do think nailing down a set that we care about is good</p>



<a name="198341395"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198341395" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198341395">(May 21 2020 at 16:19)</a>:</h4>
<p>(even if perf doesn't track it)</p>



<a name="198341415"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198341415" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198341415">(May 21 2020 at 16:19)</a>:</h4>
<p>especially as I look to expand what perf <em>does</em> track</p>



<a name="198345078"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198345078" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198345078">(May 21 2020 at 16:45)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> one thing I was commenting to <span class="user-mention" data-user-id="116083">@pnkfelix</span> is that I'd like to coordinate the effort of <span class="user-group-mention" data-user-group-id="2403">@WG-prioritization</span> with others, my feeling is that there's more people checking perf</p>



<a name="198345111"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198345111" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198345111">(May 21 2020 at 16:45)</a>:</h4>
<p>I'd like to know how can we help better</p>



<a name="198345149"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198345149" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198345149">(May 21 2020 at 16:45)</a>:</h4>
<p>what Felix have said is that it may be good that we check perf to raise awareness in weekly meetings about possible regressions</p>



<a name="198345356"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198345356" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198345356">(May 21 2020 at 16:46)</a>:</h4>
<p>that seems great but again coordinating with whoever does some work here would be nice to avoid duplication of work I guess :)</p>



<a name="198347752"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198347752" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198347752">(May 21 2020 at 17:05)</a>:</h4>
<p>I think it would be good to set an action item for compiler team to indicate what would our goals be</p>



<a name="198347780"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198347780" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198347780">(May 21 2020 at 17:05)</a>:</h4>
<p><span class="user-mention" data-user-id="120989">@Nicholas Nethercote</span> may have thoughts too</p>



<a name="198350444"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198350444" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198350444">(May 21 2020 at 17:26)</a>:</h4>
<p>more concretely are you or <span class="user-mention" data-user-id="120989">@Nicholas Nethercote</span> or somebody else periodically checking this? and in that case, what do we think the <span class="user-group-mention" data-user-group-id="2403">@WG-prioritization</span> could do, improve and bring into the table?</p>



<a name="198355198"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198355198" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198355198">(May 21 2020 at 18:05)</a>:</h4>
<p>I am, or at least to some extent.</p>



<a name="198355256"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198355256" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198355256">(May 21 2020 at 18:05)</a>:</h4>
<p>Not sure about <span class="user-mention" data-user-id="120989">@Nicholas Nethercote</span> -- I think they are, but I've not talked to them about it. I'm not sure that wg-pri needs to</p>



<a name="198357618"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198357618" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198357618">(May 21 2020 at 18:24)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/227806-t-compiler.2Fwg-prioritization/topic/perf.20checks.20by.20wg/near/198355198">said</a>:</p>
<blockquote>
<p>I am, or at least to some extent.</p>
</blockquote>
<p>do you think we could help in some way, take this task over or are we fine with you on this?</p>



<a name="198357702"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198357702" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198357702">(May 21 2020 at 18:25)</a>:</h4>
<p>the main thing the working group should be doing is raising awareness of important issues, like in this case adding performance problems to the agenda of the meeting to ensure that we discuss those</p>



<a name="198357837"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198357837" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198357837">(May 21 2020 at 18:27)</a>:</h4>
<p>just in case ... what I'm trying to do is avoid duplication of work and have more clear what the responsibilities of the wg should be with this task</p>



<a name="198358207"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198358207" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198358207">(May 21 2020 at 18:30)</a>:</h4>
<p>all I'm doing is glancing at <a href="http://perf.rust-lang.org/index.html">perf.rust-lang.org/index.html</a> somewhat regularly, I don't think it's "hard" and I'm definitely not catching 100% of cases</p>



<a name="198358427"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198358427" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198358427">(May 21 2020 at 18:32)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="198358451"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198358451" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198358451">(May 21 2020 at 18:32)</a>:</h4>
<p>I think I have a better sense of what's needed then :)</p>



<a name="198387699"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198387699" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198387699">(May 21 2020 at 22:50)</a>:</h4>
<p>Literally last week I added a calendar item to check for regressions weekly, on my Tuesday morning (Monday afternoon in North America).</p>



<a name="198387829"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198387829" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198387829">(May 21 2020 at 22:51)</a>:</h4>
<p>One thing I've always wanted is a way for trusted people to annotate individual commits on the <a href="http://perf.rust-lang.org">perf.rust-lang.org</a> graphs. E.g. if a regression happens and then is fixed, you could mark the regression commit with an annotation pointing to the fix</p>



<a name="198387983"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198387983" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198387983">(May 21 2020 at 22:53)</a>:</h4>
<p>hm that sounds like it would not be terribly hard to do</p>



<a name="198387998"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198387998" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198387998">(May 21 2020 at 22:53)</a>:</h4>
<p>For the regression hunting, this week I looked at instructions and max-rss. Cycles might also be useful, though it correlates very highly with instructions.</p>



<a name="198388005"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198388005" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198388005">(May 21 2020 at 22:53)</a>:</h4>
<p>not sure how to expose it in the UI, maybe on the compare pages</p>



<a name="198388035"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198388035" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198388035">(May 21 2020 at 22:53)</a>:</h4>
<p>Binary size would also be interesting, though we don't collect that AFAIK?</p>



<a name="198388067"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198388067" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198388067">(May 21 2020 at 22:53)</a>:</h4>
<p>I plan to soon, though I've yet to investigate <em>which</em> binaries we can look at</p>



<a name="198388068"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198388068" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198388068">(May 21 2020 at 22:53)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> The annotations would be visible on the graphs, ideally</p>



<a name="198388158"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198388158" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198388158">(May 21 2020 at 22:54)</a>:</h4>
<p><span class="user-mention" data-user-id="120989">@Nicholas Nethercote</span> -- hm, yeah, so we could color the dots? I wouldn't want to stick the text in the tooltip I think</p>



<a name="198388174"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198388174" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198388174">(May 21 2020 at 22:54)</a>:</h4>
<p>or a vertical line maybe, not sure what would be better</p>



<a name="198388183"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198388183" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198388183">(May 21 2020 at 22:54)</a>:</h4>
<p>I haven't thought carefully about the UI :)</p>



<a name="198388203"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198388203" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198388203">(May 21 2020 at 22:55)</a>:</h4>
<p>if the annotations are per-commit, then vertical lines sound reasonable</p>



<a name="198388242"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198388242" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198388242">(May 21 2020 at 22:55)</a>:</h4>
<p>they can easily be as fine-grained (or not) as we want, though being consistent would be easiest</p>



<a name="198388356"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198388356" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198388356">(May 21 2020 at 22:56)</a>:</h4>
<p>For the regression checking, here is a page for Firefox nightly crash checking that may be of interest: <a href="https://wiki.mozilla.org/NightlyCrashTriage">https://wiki.mozilla.org/NightlyCrashTriage</a></p>



<a name="198388376"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198388376" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198388376">(May 21 2020 at 22:56)</a>:</h4>
<p>I wrote most of that page, I started up the nightly triage, though I haven't done been involved for a while now</p>



<a name="198388435"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198388435" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198388435">(May 21 2020 at 22:57)</a>:</h4>
<p>Key things: a roster, general instructions on how to do it (useful when someone goes on PTO and someone else takes over, or a new person starts doing it), a place for notes</p>



<a name="198388500"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198388500" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198388500">(May 21 2020 at 22:58)</a>:</h4>
<p>I'd be happy to write something similar for rustc perf checking, I just need to be told where it would live :)</p>



<a name="198389381"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/227806-t-compiler/wg-prioritization/topic/perf%20checks%20by%20wg/near/198389381" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/227806-t-compiler/wg-prioritization/topic/perf.20checks.20by.20wg.html#198389381">(May 21 2020 at 23:07)</a>:</h4>
<p>Forge seems good, or rustc-perf maybe (GitHub wiki or just a file in root)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>